You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR also partially resolves some of the test issues when building in a Windows environment as described in https://issues.apache.org/jira/browse/LIVY-611. It does not resolve all of the issues with running tests on a windows environment. For example integration tests will fail because of line 299 of MiniCluster.scala (sys.process.Process(s"pkill -f $simpleName")). I believe that with the changes in this PR, should be able to resolve LIVY-611 with a future PR.
How was this patch tested?
Unit tests for new class, and I was able to start up a livy server (with java -cp "./jars/*;./conf;" org.apache.livy.server.LivyServer) on a Docker windows container and submit spark requests to the livy server successfully.
@jerryshao And sorry for my late reply! I believe this PR should resolve issues with running the Livy server on Windows (at least with my tests). However it does not resolve developing on windows. LIVY-611 refers specifically to integration/unit tests. For example in the MiniCluster.scala integration test, some calls use unix based commands. However at the very least this PR should allow users to run a Livy server on a Windows machine, and with the changes it brings, it shouldn't be too hard to then resolve LIVY-611.
This pull request has been automatically marked as stale because it has had no activity for at least 3 months. If you are still working on this change or plan to move it forward, please leave a comment or push a new commit so we know to keep it open. Otherwise, this PR will be closed automatically in about one month. Thank you for your contribution to Apache Livy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The ability to start up a Livy server on a Windows Operating System.
(https://issues.apache.org/jira/browse/LIVY-643)
This PR also partially resolves some of the test issues when building in a Windows environment as described in https://issues.apache.org/jira/browse/LIVY-611. It does not resolve all of the issues with running tests on a windows environment. For example integration tests will fail because of line 299 of MiniCluster.scala (sys.process.Process(s"pkill -f $simpleName")). I believe that with the changes in this PR, should be able to resolve LIVY-611 with a future PR.
How was this patch tested?
Unit tests for new class, and I was able to start up a livy server (with java -cp "./jars/*;./conf;" org.apache.livy.server.LivyServer) on a Docker windows container and submit spark requests to the livy server successfully.